From 4429a3d481058d509ce76962bb39a341835cb03a Mon Sep 17 00:00:00 2001
From: Yassine Doghri <yassine@doghri.fr>
Date: Thu, 20 May 2021 17:53:25 +0000
Subject: [PATCH] ci: fix PersonModel issues with static analysis

---
 app/Models/PersonModel.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/Models/PersonModel.php b/app/Models/PersonModel.php
index 74f5598dd2..293c122e1a 100644
--- a/app/Models/PersonModel.php
+++ b/app/Models/PersonModel.php
@@ -10,7 +10,6 @@ namespace App\Models;
 
 use App\Entities\Image;
 use App\Entities\Person;
-use CodeIgniter\Database\BaseResult;
 use CodeIgniter\Database\Query;
 use CodeIgniter\Model;
 
@@ -172,6 +171,7 @@ class PersonModel extends Model
             ->getLocale();
         $cacheName = "taxonomy_options_{$locale}";
 
+        /** @var array<string, array<string, string|array<string, array<string, string>>>> $personsTaxonomy */
         $personsTaxonomy = lang('PersonsTaxonomy.persons');
 
         if (! ($options = cache($cacheName))) {
@@ -327,9 +327,9 @@ class PersonModel extends Model
     /**
      * Add persons to episode
      *
-     * @return BaseResult|bool Number of rows inserted or FALSE on failure
+     * @return string|bool Number of rows inserted or FALSE on failure
      */
-    public function removePersonFromPodcast(int $podcastId, int $personId): bool | string
+    public function removePersonFromPodcast(int $podcastId, int $personId): string | bool
     {
         return $this->db->table('podcasts_persons')
             ->delete([
-- 
GitLab