From 90533be0298249e5527870c01329fce5f94ec2dc Mon Sep 17 00:00:00 2001
From: Yassine Doghri <yassine@doghri.fr>
Date: Thu, 24 Feb 2022 16:32:50 +0000
Subject: [PATCH] feat: make episode description more visible on episode pages
- double the height of the episode description on episode pages
- reduce overlay fading by 70% to
make it more subtle
closes #171
---
app/Resources/styles/seeMore.css | 4 ++--
app/Views/Components/SeeMore.php | 2 +-
themes/cp_app/episode/_layout.php | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/app/Resources/styles/seeMore.css b/app/Resources/styles/seeMore.css
index d535afb847..4166b147eb 100644
--- a/app/Resources/styles/seeMore.css
+++ b/app/Resources/styles/seeMore.css
@@ -5,14 +5,14 @@
.see-more__content {
@apply relative overflow-hidden;
- height: 5rem;
+ height: var(--content-height);
}
.see-more_content-fade {
@apply absolute bottom-0 left-0 w-full h-full pointer-events-none;
background-image: linear-gradient(
to bottom,
- transparent,
+ transparent 70%,
hsl(var(--color-background-header))
);
}
diff --git a/app/Views/Components/SeeMore.php b/app/Views/Components/SeeMore.php
index 22481be711..19f247f273 100644
--- a/app/Views/Components/SeeMore.php
+++ b/app/Views/Components/SeeMore.php
@@ -13,7 +13,7 @@ class SeeMore extends Component
$seeMoreLabel = lang('Common.see_more');
$seeLessLabel = lang('Common.see_less');
return <<<HTML
- <div class="see-more" style="--line-clamp: 3">
+ <div class="see-more" style="--content-height: 10rem">
<input id="see-more-checkbox" type="checkbox" class="see-more__checkbox" aria-hidden="true">
<div class="mb-2 see-more__content {$this->class}"><div class="see-more_content-fade"></div>{$this->slot}</div>
<label for="see-more-checkbox" class="see-more__label" data-see-more="{$seeMoreLabel}" data-see-less="{$seeLessLabel}" aria-hidden="true"></label>
diff --git a/themes/cp_app/episode/_layout.php b/themes/cp_app/episode/_layout.php
index 1914950667..ddbfd16e56 100644
--- a/themes/cp_app/episode/_layout.php
+++ b/themes/cp_app/episode/_layout.php
@@ -132,7 +132,7 @@
</header>
<div class="col-start-2 px-8 py-4 text-white bg-header">
<h2 class="text-xs font-bold tracking-wider uppercase whitespace-pre-line font-display"><?= lang('Episode.description') ?></h2>
- <?php if (substr_count($episode->description_markdown, "\n") > 3 || strlen($episode->description) > 250): ?>
+ <?php if (substr_count($episode->description_markdown, "\n") > 6 || strlen($episode->description) > 500): ?>
<SeeMore class="max-w-xl prose-sm text-white"><?= $episode->getDescriptionHtml('-+Website+-') ?></SeeMore>
<?php else: ?>
<div class="max-w-xl prose-sm text-white"><?= $episode->getDescriptionHtml('-+Website+-') ?></div>
--
GitLab