From db191ac31bd16bad2a72afdb8b25c685adf86a6e Mon Sep 17 00:00:00 2001
From: Yassine Doghri <yassine@doghri.fr>
Date: Fri, 21 Jan 2022 18:29:39 +0000
Subject: [PATCH] fix: add translation key for audio-clipper trim labels
---
app/Resources/js/modules/audio-clipper.ts | 14 ++++++++++++--
modules/Admin/Language/en/VideoClip.php | 2 ++
modules/Admin/Language/fr/VideoClip.php | 2 ++
themes/cp_admin/episode/soundbites_new.php | 2 +-
themes/cp_admin/episode/video_clips_new.php | 2 +-
5 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/app/Resources/js/modules/audio-clipper.ts b/app/Resources/js/modules/audio-clipper.ts
index e77b4d2e5c..18df16e0f3 100644
--- a/app/Resources/js/modules/audio-clipper.ts
+++ b/app/Resources/js/modules/audio-clipper.ts
@@ -75,6 +75,12 @@ export class AudioClipper extends LitElement {
@property({ type: Number, attribute: "height" })
height = 100;
+ @property({ attribute: "trim-start-label" })
+ trimStartLabel = "Trim start";
+
+ @property({ attribute: "trim-end-label" })
+ trimEndLabel = "Trim end";
+
@state()
_isPlaying = false;
@@ -853,8 +859,12 @@ export class AudioClipper extends LitElement {
<time>${this.secondsToHHMMSS(this._currentTime)}</time>
</div>
<div class="toolbar__trim-controls">
- <button @click="${() => this.trim("start")}">Trim start</button>
- <button @click="${() => this.trim("end")}">Trim end</button>
+ <button @click="${() => this.trim("start")}">
+ ${this.trimStartLabel}
+ </button>
+ <button @click="${() => this.trim("end")}">
+ ${this.trimEndLabel}
+ </button>
</div>
</div>
`;
diff --git a/modules/Admin/Language/en/VideoClip.php b/modules/Admin/Language/en/VideoClip.php
index c8335c6296..e7845852e6 100644
--- a/modules/Admin/Language/en/VideoClip.php
+++ b/modules/Admin/Language/en/VideoClip.php
@@ -57,6 +57,8 @@ return [
'theme' => 'Select a theme',
'start_time' => 'Start at',
'duration' => 'Duration',
+ 'trim_start' => 'Trim start',
+ 'trim_end' => 'Trim end',
'submit' => 'Create video clip',
],
'requirements' => [
diff --git a/modules/Admin/Language/fr/VideoClip.php b/modules/Admin/Language/fr/VideoClip.php
index 6154a22467..a7d1069b24 100644
--- a/modules/Admin/Language/fr/VideoClip.php
+++ b/modules/Admin/Language/fr/VideoClip.php
@@ -57,6 +57,8 @@ return [
'theme' => 'Sélectionnez un thème',
'start_time' => 'Démarrer à',
'duration' => 'Durée',
+ 'trim_start' => 'Rogner le début',
+ 'trim_end' => 'Rogner la fin',
'submit' => 'Créer un extrait vidéo',
],
'requirements' => [
diff --git a/themes/cp_admin/episode/soundbites_new.php b/themes/cp_admin/episode/soundbites_new.php
index 0452d37d98..f5609494fc 100644
--- a/themes/cp_admin/episode/soundbites_new.php
+++ b/themes/cp_admin/episode/soundbites_new.php
@@ -20,7 +20,7 @@
required="true"
class="max-w-sm"
/>
- <audio-clipper start-time="<?= old('start_time', 0) ?>" duration="<?= old('duration', 30) ?>" min-duration="10" volume=".5" height="50" class="mt-8">
+ <audio-clipper start-time="<?= old('start_time', 0) ?>" duration="<?= old('duration', 30) ?>" min-duration="10" volume=".5" height="50" trim-start-label="<?= lang('VideoClip.form.trim_start') ?>" trim-end-label="<?= lang('VideoClip.form.trim_end') ?>" class="mt-8">
<audio slot="audio" src="<?= $episode->audio->file_url ?>" preload="auto">
Your browser does not support the <code>audio</code> element.
</audio>
diff --git a/themes/cp_admin/episode/video_clips_new.php b/themes/cp_admin/episode/video_clips_new.php
index 89a002ff7a..8819a41f6f 100644
--- a/themes/cp_admin/episode/video_clips_new.php
+++ b/themes/cp_admin/episode/video_clips_new.php
@@ -16,7 +16,7 @@
<video-clip-previewer duration="<?= old('duration', 30) ?>">
<img slot="preview_image" src="<?= $episode->cover->thumbnail_url ?>" alt="<?= $episode->cover->description ?>" loading="lazy" />
</video-clip-previewer>
- <audio-clipper start-time="<?= old('start_time', 0) ?>" duration="<?= old('duration', 30) ?>" min-duration="10" volume=".5" height="50">
+ <audio-clipper start-time="<?= old('start_time', 0) ?>" duration="<?= old('duration', 30) ?>" min-duration="10" volume=".5" height="50" trim-start-label="<?= lang('VideoClip.form.trim_start') ?>" trim-end-label="<?= lang('VideoClip.form.trim_end') ?>">
<audio slot="audio" src="<?= $episode->audio->file_url ?>" preload="auto">
Your browser does not support the <code>audio</code> element.
</audio>
--
GitLab