Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
Castopod
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Ad Aures
Castopod
Commits
f3785e14
Commit
f3785e14
authored
3 years ago
by
Yassine Doghri
Browse files
Options
Downloads
Patches
Plain Diff
fix(a11y): replace active tab color to contrast with background on podcast and episode pages
parent
06b1a8b2
Branches
Branches containing commit
Tags
Tags containing commit
2 merge requests
!160
WIP:Feat/social interact
,
!150
fix(ux): enhance user experience
Pipeline
#1228
passed
3 years ago
Stage: prepare
Stage: quality
Stage: bundle
Changes
2
Pipelines
1
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
themes/cp_app/episode/_partials/navigation.php
+1
-1
1 addition, 1 deletion
themes/cp_app/episode/_partials/navigation.php
themes/cp_app/podcast/_partials/navigation.php
+1
-1
1 addition, 1 deletion
themes/cp_app/podcast/_partials/navigation.php
with
2 additions
and
2 deletions
themes/cp_app/episode/_partials/navigation.php
+
1
−
1
View file @
f3785e14
...
...
@@ -16,7 +16,7 @@ $navigationItems = [
<nav
class=
"sticky z-40 flex col-start-2 pt-4 shadow bg-elevated md:px-8 gap-x-2 md:gap-x-4 -top-4 rounded-conditional-b-xl"
>
<?php
foreach
(
$navigationItems
as
$item
)
:
?>
<?php
$isActive
=
url_is
(
$item
[
'uri'
]);
?>
<a
href=
"
<?=
$item
[
'uri'
]
?>
"
class=
"px-4 py-1 text-sm font-semibold uppercase focus:ring-accent border-b-4
<?=
$isActive
?
' border-b-4 text-
accent-base
border-accent-base'
:
' text-skin-muted hover:text-skin-base hover:border-subtle border-transparent'
?>
"
>
<?=
$item
[
'label'
]
?>
<span
class=
"px-2 ml-1 font-semibold rounded-full bg-base"
>
<?=
$item
[
'labelInfo'
]
?>
</span></a>
<a
href=
"
<?=
$item
[
'uri'
]
?>
"
class=
"px-4 py-1 text-sm font-semibold uppercase focus:ring-accent border-b-4
<?=
$isActive
?
' border-b-4 text-
black
border-accent-base'
:
' text-skin-muted hover:text-skin-base hover:border-subtle border-transparent'
?>
"
>
<?=
$item
[
'label'
]
?>
<span
class=
"px-2 ml-1 font-semibold rounded-full bg-base"
>
<?=
$item
[
'labelInfo'
]
?>
</span></a>
<?php
endforeach
;
?>
<button
type=
"button"
class=
"p-2 ml-auto rotate-180 rounded-full md:hidden focus:ring-accent"
data-sidebar-toggler=
"toggler"
aria-label=
"
<?=
lang
(
'Navigation.toggle_sidebar'
)
?>
"
>
<?=
icon
(
'menu'
)
?>
</button>
</nav>
\ No newline at end of file
This diff is collapsed.
Click to expand it.
themes/cp_app/podcast/_partials/navigation.php
+
1
−
1
View file @
f3785e14
...
...
@@ -18,7 +18,7 @@ $navigationItems = [
<nav
class=
"sticky z-40 flex col-start-2 pt-8 shadow bg-elevated gap-x-2 md:gap-x-4 md:px-8 -top-6 md:-top-10 rounded-conditional-b-xl md:pt-12 "
>
<?php
foreach
(
$navigationItems
as
$item
)
:
?>
<?php
$isActive
=
url_is
(
$item
[
'uri'
]);
?>
<a
href=
"
<?=
$item
[
'uri'
]
?>
"
class=
"px-4 py-1 text-sm font-semibold uppercase focus:ring-accent border-b-4
<?=
$isActive
?
' border-b-4 text-
accent-base
border-accent-base'
:
' text-skin-muted hover:text-skin-base hover:border-subtle border-transparent'
?>
"
>
<?=
$item
[
'label'
]
?>
</a>
<a
href=
"
<?=
$item
[
'uri'
]
?>
"
class=
"px-4 py-1 text-sm font-semibold uppercase focus:ring-accent border-b-4
<?=
$isActive
?
' border-b-4 text-
black
border-accent-base'
:
' text-skin-muted hover:text-skin-base hover:border-subtle border-transparent'
?>
"
>
<?=
$item
[
'label'
]
?>
</a>
<?php
endforeach
;
?>
<button
type=
"button"
class=
"p-2 ml-auto rotate-180 rounded-full md:hidden focus:ring-accent"
data-sidebar-toggler=
"toggler"
aria-label=
"
<?=
lang
(
'Navigation.toggle_sidebar'
)
?>
"
>
<?=
icon
(
'menu'
)
?>
</button>
</nav>
\ No newline at end of file
This diff is collapsed.
Click to expand it.
Yassine Doghri
@yassinedoghri
mentioned in commit
d807ab97
·
3 years ago
mentioned in commit
d807ab97
mentioned in commit d807ab9732d8e4ad1eae956f0b728f8a5c0f868d
Toggle commit list
Yassine Doghri
@yassinedoghri
mentioned in commit
f9572e41
·
2 years ago
mentioned in commit
f9572e41
mentioned in commit f9572e4125ed53c215cc4a3c4d1a32708e6febe3
Toggle commit list
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment