From 5dc0f19656de0d764f627d6ae78a9e306c901835 Mon Sep 17 00:00:00 2001
From: Yassine Doghri <yassine@doghri.fr>
Date: Tue, 8 Dec 2020 10:14:24 +0000
Subject: [PATCH] revert(soundbites): remove soundbite table from episode's
public page
Soundbites are a mean to tease the episode, putting them in the episode page is unnecessary.
---
app/Views/_assets/admin.ts | 2 ++
app/Views/_assets/soundbites.ts | 3 --
app/Views/admin/_layout.php | 1 -
app/Views/episode.php | 50 +--------------------------------
4 files changed, 3 insertions(+), 53 deletions(-)
delete mode 100644 app/Views/_assets/soundbites.ts
diff --git a/app/Views/_assets/admin.ts b/app/Views/_assets/admin.ts
index d05abf005a..1c54fec275 100644
--- a/app/Views/_assets/admin.ts
+++ b/app/Views/_assets/admin.ts
@@ -5,6 +5,7 @@ import MarkdownEditor from "./modules/MarkdownEditor";
import MultiSelect from "./modules/MultiSelect";
import SidebarToggler from "./modules/SidebarToggler";
import Slugify from "./modules/Slugify";
+import Soundbites from "./modules/Soundbites";
import Time from "./modules/Time";
import Tooltip from "./modules/Tooltip";
@@ -17,3 +18,4 @@ SidebarToggler();
ClientTimezone();
DateTimePicker();
Time();
+Soundbites();
diff --git a/app/Views/_assets/soundbites.ts b/app/Views/_assets/soundbites.ts
deleted file mode 100644
index fa8b6be116..0000000000
--- a/app/Views/_assets/soundbites.ts
+++ /dev/null
@@ -1,3 +0,0 @@
-import Soundbites from "./modules/Soundbites";
-
-Soundbites();
diff --git a/app/Views/admin/_layout.php b/app/Views/admin/_layout.php
index 3f1289cc29..6a8d170667 100644
--- a/app/Views/admin/_layout.php
+++ b/app/Views/admin/_layout.php
@@ -10,7 +10,6 @@
<link rel="stylesheet" href="/assets/admin.css"/>
<link rel="stylesheet" href="/assets/index.css"/>
<script src="/assets/admin.js" type="module" defer></script>
- <script src="/assets/soundbites.js" type="module" defer></script>
</head>
<body class="relative bg-gray-100 holy-grail-grid">
diff --git a/app/Views/episode.php b/app/Views/episode.php
index 08a6ae1191..2fbcf29a89 100644
--- a/app/Views/episode.php
+++ b/app/Views/episode.php
@@ -15,7 +15,6 @@
<link rel="stylesheet" href="/assets/index.css"/>
<link rel="canonical" href="<?= current_url() ?>" />
<script src="/assets/podcast.js" type="module" defer></script>
- <script src="/assets/soundbites.js" type="module" defer></script>
<meta property="og:title" content="<?= $episode->title ?>" />
<meta property="og:locale" content="<?= $podcast->language_code ?>" />
<meta property="og:site_name" content="<?= $podcast->title ?>" />
@@ -106,54 +105,7 @@
Your browser does not support the audio tag.
</audio>
</div>
- </header>
-
- <?php if (count($episode->soundbites) > 0): ?>
- <div class="w-full max-w-3xl px-2 py-6 mx-auto md:px-6">
- <?= data_table(
- [
- [
- 'header' => lang('Episode.soundbites'),
- 'cell' => function ($soundbite) {
- return icon_button(
- 'play',
- lang('Episode.soundbites_form.play'),
- null,
- ['variant' => 'primary'],
- [
- 'class' => 'mb-1 mr-1',
- 'data-type' => 'play-soundbite',
- 'data-soundbite-start-time' =>
- $soundbite->start_time,
- 'data-soundbite-duration' => $soundbite->duration,
- ]
- );
- },
- ],
- [
- 'header' => lang('Episode.soundbites_form.start_time'),
- 'cell' => function ($soundbite) {
- return format_duration($soundbite->start_time);
- },
- ],
- [
- 'header' => lang('Episode.soundbites_form.duration'),
- 'cell' => function ($soundbite) {
- return format_duration($soundbite->duration);
- },
- ],
- [
- 'header' => lang('Episode.soundbites_form.label'),
- 'cell' => function ($soundbite) {
- return $soundbite->label;
- },
- ],
- ],
- $episode->soundbites
- ) ?>
- </div>
-<?php endif; ?>
-
+ </header>
<section class="w-full max-w-3xl px-2 py-6 mx-auto prose md:px-6">
<?= $episode->description_html ?>
</section>
--
GitLab