From 8d9bba4e9f18767775200aa17b8c326dcef215e8 Mon Sep 17 00:00:00 2001
From: Yassine Doghri <yassine@doghri.fr>
Date: Fri, 11 Jun 2021 08:53:14 +0000
Subject: [PATCH] refactor: clean episode analytics url by removing `podcasts/`
prefix
---
app/Entities/Episode.php | 5 ++++-
.../Analytics/Controllers/EpisodeAnalyticsController.php | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/app/Entities/Episode.php b/app/Entities/Episode.php
index 243586e0ea..9556b3e94d 100644
--- a/app/Entities/Episode.php
+++ b/app/Entities/Episode.php
@@ -296,10 +296,13 @@ class Episode extends Entity
{
helper('analytics');
+ // remove 'podcasts/' from audio file path
+ $strippedAudioFilePath = substr($this->audio_file_path, 9);
+
return generate_episode_analytics_url(
$this->podcast_id,
$this->id,
- $this->audio_file_path,
+ $strippedAudioFilePath,
$this->audio_file_duration,
$this->audio_file_size,
$this->audio_file_header_size,
diff --git a/app/Libraries/Analytics/Controllers/EpisodeAnalyticsController.php b/app/Libraries/Analytics/Controllers/EpisodeAnalyticsController.php
index 05ae1462d0..683dcbdccd 100644
--- a/app/Libraries/Analytics/Controllers/EpisodeAnalyticsController.php
+++ b/app/Libraries/Analytics/Controllers/EpisodeAnalyticsController.php
@@ -77,6 +77,6 @@ class EpisodeAnalyticsController extends Controller
$serviceName,
);
- return redirect()->to($this->config->getAudioFileUrl($audioFilePath));
+ return redirect()->to($this->config->getAudioFileUrl(['podcasts', ...$audioFilePath]));
}
}
--
GitLab