From 7180ae9ec700930b69c04ed91f8eceea16ad77ce Mon Sep 17 00:00:00 2001
From: Yassine Doghri <yassine@doghri.fr>
Date: Tue, 5 Oct 2021 13:23:23 +0000
Subject: [PATCH] fix(rss): cast number type values to string in rss_helper
fixes #148
---
app/Helpers/rss_helper.php | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/app/Helpers/rss_helper.php b/app/Helpers/rss_helper.php
index 502b2f7b87..e785206ccf 100644
--- a/app/Helpers/rss_helper.php
+++ b/app/Helpers/rss_helper.php
@@ -229,7 +229,7 @@ if (! function_exists('get_rss_feed')) {
}
}
$item->addChildWithCDATA('description', $episode->getDescriptionHtml($serviceSlug));
- $item->addChild('duration', $episode->audio_file_duration, $itunesNamespace);
+ $item->addChild('duration', (string) $episode->audio_file_duration, $itunesNamespace);
$item->addChild('link', $episode->link);
$episodeItunesImage = $item->addChild('image', null, $itunesNamespace);
$episodeItunesImage->addAttribute('href', $episode->image->feed_url);
@@ -244,9 +244,9 @@ if (! function_exists('get_rss_feed')) {
);
$episode->number &&
- $item->addChild('episode', $episode->number, $itunesNamespace);
+ $item->addChild('episode', (string) $episode->number, $itunesNamespace);
$episode->season_number &&
- $item->addChild('season', $episode->season_number, $itunesNamespace);
+ $item->addChild('season', (string) $episode->season_number, $itunesNamespace);
$item->addChild('episodeType', $episode->type, $itunesNamespace);
// add link to episode comments as podcast-activity format
@@ -272,8 +272,8 @@ if (! function_exists('get_rss_feed')) {
foreach ($episode->soundbites as $soundbite) {
$soundbiteElement = $item->addChild('soundbite', $soundbite->label, $podcastNamespace);
- $soundbiteElement->addAttribute('start_time', $soundbite->start_time);
- $soundbiteElement->addAttribute('duration', $soundbite->duration);
+ $soundbiteElement->addAttribute('start_time', (string) $soundbite->start_time);
+ $soundbiteElement->addAttribute('duration', (string) $soundbite->duration);
}
foreach ($episode->persons as $person) {
--
GitLab