diff --git a/app/Libraries/ActivityPub/Controllers/ActorController.php b/app/Libraries/ActivityPub/Controllers/ActorController.php index e8feb89f0d54f5f5d0a3368b1eb8dddc24a88b43..88b4dbd62aaa28f4cbe87f03373d7b4c3c3615a3 100644 --- a/app/Libraries/ActivityPub/Controllers/ActorController.php +++ b/app/Libraries/ActivityPub/Controllers/ActorController.php @@ -48,7 +48,10 @@ class ActorController extends Controller return $this->{$method}(...$params); } - public function index(): RedirectResponse + /** + * @noRector ReturnTypeDeclarationRector + */ + public function index(): ResponseInterface { $actorObjectClass = $this->config->actorObject; $actorObject = new $actorObjectClass($this->actor); @@ -60,6 +63,8 @@ class ActorController extends Controller /** * Handles incoming requests from fediverse servers + * + * @noRector ReturnTypeDeclarationRector */ public function inbox(): ResponseInterface { @@ -228,7 +233,10 @@ class ActorController extends Controller } } - public function outbox(): RedirectResponse + /** + * @noRector ReturnTypeDeclarationRector + */ + public function outbox(): ResponseInterface { // get published activities by publication date $actorActivity = model('ActivityModel') @@ -257,7 +265,10 @@ class ActorController extends Controller ->setBody($collection->toJSON()); } - public function followers(): RedirectResponse + /** + * @noRector ReturnTypeDeclarationRector + */ + public function followers(): ResponseInterface { // get followers for a specific actor $followers = model('ActorModel') @@ -334,7 +345,10 @@ class ActorController extends Controller ); } - public function activity(string $activityId): RedirectResponse + /** + * @noRector ReturnTypeDeclarationRector + */ + public function activity(string $activityId): ResponseInterface { if ( ! ($activity = model('ActivityModel')->getActivityById($activityId)) diff --git a/app/Libraries/ActivityPub/Core/ObjectType.php b/app/Libraries/ActivityPub/Core/ObjectType.php index bfd0c4b3019053ecfbef73b6b1a53251b2a9ef2d..2d873400601f833de4ea1d57c0896c16699c1c04 100644 --- a/app/Libraries/ActivityPub/Core/ObjectType.php +++ b/app/Libraries/ActivityPub/Core/ObjectType.php @@ -33,7 +33,7 @@ class ObjectType extends AbstractObject protected array $to = ['https://www.w3.org/ns/activitystreams#Public']; /** - * @var string[] + * @var string[]|null */ - protected array $cc = []; + protected ?array $cc = null; } diff --git a/app/Libraries/ActivityPub/Models/ActorModel.php b/app/Libraries/ActivityPub/Models/ActorModel.php index 0c98e9f64eae0df01619b460786829c4e5e0b030..789714f519df2c9ed879c0402276350b03a08a73 100644 --- a/app/Libraries/ActivityPub/Models/ActorModel.php +++ b/app/Libraries/ActivityPub/Models/ActorModel.php @@ -84,7 +84,10 @@ class ActorModel extends Model $domain = get_current_domain(); } - $cacheName = "actor-{$username}-{$domain}"; + // remove colons for port if set + $cacheDomain = str_replace(':', '', $domain); + + $cacheName = "actor-{$username}-{$cacheDomain}"; if (! ($found = cache($cacheName))) { $found = $this->where([ 'username' => $username,