From e5b75150234bd7f19e01def93425d3bda7379dd3 Mon Sep 17 00:00:00 2001
From: Yassine Doghri <yassine@doghri.fr>
Date: Fri, 28 May 2021 07:56:06 +0000
Subject: [PATCH] fix: update broken contributor dropdown fields

---
 app/Language/en/Contributor.php     | 2 ++
 app/Language/fr/Contributor.php     | 4 +++-
 app/Views/admin/contributor/add.php | 6 ++++--
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/app/Language/en/Contributor.php b/app/Language/en/Contributor.php
index 4021ad9d1e..629d44910f 100644
--- a/app/Language/en/Contributor.php
+++ b/app/Language/en/Contributor.php
@@ -20,7 +20,9 @@ return [
     ],
     'form' => [
         'user' => 'User',
+        'user_placeholder' => 'Select a user…',
         'role' => 'Role',
+        'role_placeholder' => 'Select its role…',
         'submit_add' => 'Add contributor',
         'submit_edit' => 'Update role',
     ],
diff --git a/app/Language/fr/Contributor.php b/app/Language/fr/Contributor.php
index 66728696dd..1e59c0c652 100644
--- a/app/Language/fr/Contributor.php
+++ b/app/Language/fr/Contributor.php
@@ -19,8 +19,10 @@ return [
         'role' => 'Rôle',
     ],
     'form' => [
-        'user' => 'Identifiant',
+        'user' => 'Utilisateur',
+        'user_placeholder' => 'Sélectionnez un utilisateur…',
         'role' => 'Rôle',
+        'role_placeholder' => 'Sélectionnez son rôle…',
         'submit_add' => 'Ajouter le contributeur',
         'submit_edit' => 'Mettre à jour le rôle',
     ],
diff --git a/app/Views/admin/contributor/add.php b/app/Views/admin/contributor/add.php
index 4bd2381c3f..38f3efa45e 100644
--- a/app/Views/admin/contributor/add.php
+++ b/app/Views/admin/contributor/add.php
@@ -17,17 +17,19 @@
 <?= csrf_field() ?>
     
 <?= form_label(lang('Contributor.form.user'), 'user') ?>
-<?= form_dropdown('user', $userOptions, old('user'), [
+<?= form_dropdown('user', $userOptions, old('user', ''), [
     'id' => 'user',
     'class' => 'form-select mb-4',
     'required' => 'required',
+    'placeholder' => lang('Contributor.form.user_placeholder')
 ]) ?>
 
 <?= form_label(lang('Contributor.form.role'), 'role') ?>
-<?= form_dropdown('role', $roleOptions, old('role'), [
+<?= form_dropdown('role', $roleOptions, old('role', ''), [
     'id' => 'role',
     'class' => 'form-select mb-4',
     'required' => 'required',
+    'placeholder' => lang('Contributor.form.role_placeholder')
 ]) ?>
 
 <?= button(
-- 
GitLab