Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
Castopod
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Albatroz Jeremias
Castopod
Commits
32e8c7c1
Unverified
Commit
32e8c7c1
authored
3 years ago
by
Yassine Doghri
Browse files
Options
Downloads
Patches
Plain Diff
feat(rss): add podcast:comments tag to link to episode comments
parent
ed8dc005
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
.devcontainer/devcontainer.json
+1
-1
1 addition, 1 deletion
.devcontainer/devcontainer.json
app/Helpers/rss_helper.php
+5
-0
5 additions, 0 deletions
app/Helpers/rss_helper.php
docs/setup-development.md
+11
-7
11 additions, 7 deletions
docs/setup-development.md
with
17 additions
and
8 deletions
.devcontainer/devcontainer.json
+
1
−
1
View file @
32e8c7c1
...
@@ -6,7 +6,7 @@
...
@@ -6,7 +6,7 @@
"service"
:
"app"
,
"service"
:
"app"
,
"workspaceFolder"
:
"/castopod-host"
,
"workspaceFolder"
:
"/castopod-host"
,
"postCreateCommand"
:
"composer install && npm install && npm run build:static"
,
"postCreateCommand"
:
"composer install && npm install && npm run build:static"
,
"postStartCommand"
:
"crontab ./crontab && cron && php spark serve --host 0.0.0.0
& npm run dev
"
,
"postStartCommand"
:
"crontab ./crontab && cron && php spark serve --host 0.0.0.0"
,
"postAttachCommand"
:
"crontab ./crontab && service cron reload"
,
"postAttachCommand"
:
"crontab ./crontab && service cron reload"
,
"shutdownAction"
:
"stopCompose"
,
"shutdownAction"
:
"stopCompose"
,
"settings"
:
{
"settings"
:
{
...
...
This diff is collapsed.
Click to expand it.
app/Helpers/rss_helper.php
+
5
−
0
View file @
32e8c7c1
...
@@ -249,6 +249,11 @@ if (! function_exists('get_rss_feed')) {
...
@@ -249,6 +249,11 @@ if (! function_exists('get_rss_feed')) {
$item
->
addChild
(
'season'
,
$episode
->
season_number
,
$itunesNamespace
);
$item
->
addChild
(
'season'
,
$episode
->
season_number
,
$itunesNamespace
);
$item
->
addChild
(
'episodeType'
,
$episode
->
type
,
$itunesNamespace
);
$item
->
addChild
(
'episodeType'
,
$episode
->
type
,
$itunesNamespace
);
// add link to episode comments as podcast-activity format
$comments
=
$item
->
addChild
(
'comments'
,
null
,
$podcastNamespace
);
$comments
->
addAttribute
(
'uri'
,
url_to
(
'episode-comments'
,
$podcast
->
name
,
$episode
->
slug
));
$comments
->
addAttribute
(
'contentType'
,
'application/podcast-activity+json'
);
if
(
$episode
->
transcript_file_url
)
{
if
(
$episode
->
transcript_file_url
)
{
$transcriptElement
=
$item
->
addChild
(
'transcript'
,
null
,
$podcastNamespace
);
$transcriptElement
=
$item
->
addChild
(
'transcript'
,
null
,
$podcastNamespace
);
$transcriptElement
->
addAttribute
(
'url'
,
$episode
->
transcript_file_url
);
$transcriptElement
->
addAttribute
(
'url'
,
$episode
->
transcript_file_url
);
...
...
This diff is collapsed.
Click to expand it.
docs/setup-development.md
+
11
−
7
View file @
32e8c7c1
...
@@ -90,19 +90,23 @@ required services will be loaded automagically!
...
@@ -90,19 +90,23 @@ required services will be loaded automagically!
> The VSCode window will reload inside the dev container. Expect several
> The VSCode window will reload inside the dev container. Expect several
> minutes during first load as it is building all necessary services.
> minutes during first load as it is building all necessary services.
**Note**
: The dev container will start by running both the Castopod Host
**Note**
: The dev container will start by running Castopod Host's php server.
server and
[
Vite
](
https://vitejs.dev
)
's dev server (for compiling the
During development, you will have to start
[
Vite
](
https://vitejs.dev
)
's dev
typescript code and styles). If there is any issue with the servers not
server for compiling the typescript code and styles:
running, you can restart them using the following commands:
```
bash
```
bash
# run Castopod host server
php spark serve
--host
0.0.0.0
# run Vite dev server
# run Vite dev server
npm run dev
npm run dev
```
```
If there is any issue with the php server not running, you can restart them
using the following commands:
```
bash
# run Castopod host server
php spark serve
--host
0.0.0.0
```
3.
You're all set! 🎉
3.
You're all set! 🎉
You're now
**inside the dev container**
, you may use the VSCode console
You're now
**inside the dev container**
, you may use the VSCode console
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment